Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bogus overload in tests #16490

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Remove bogus overload in tests #16490

merged 1 commit into from
Mar 11, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 10, 2023

The rubixEnabledConfig was ignored.

@findepi findepi requested a review from raunaqmorarka March 10, 2023 11:28
@cla-bot cla-bot bot added the cla-signed label Mar 10, 2023
@github-actions github-actions bot added hive Hive connector tests:hive labels Mar 10, 2023
@raunaqmorarka raunaqmorarka requested a review from sopel39 March 10, 2023 13:22
sopel39
sopel39 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only if it's really not used!

@findepi
Copy link
Member Author

findepi commented Mar 10, 2023

as you see from the code changes it was used in TestRubixCaching.java (but in void)

@findepi
Remove bogus overload in tests
423a920 
The `rubixEnabledConfig` was ignored.
@findepi findepi force-pushed the findepi/remove-bogus-overload-in-tests-4ebd4d branch from 1b27862 to 423a920 Compare March 10, 2023 13:58
@findepi findepi merged commit d458875 into trinodb:master Mar 11, 2023
@findepi findepi deleted the findepi/remove-bogus-overload-in-tests-4ebd4d branch March 11, 2023 21:26
@github-actions github-actions bot added this to the 411 milestone Mar 11, 2023
@colebow colebow mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopel39 sopel39 sopel39 approved these changes

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

Assignees
No one assigned
Labels
cla-signed hive Hive connector
Milestone
411
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @raunaqmorarka @sopel39