Don't enforce top-level repo name in BaseCostBasedPlanTest #16486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engineers will typically check out the repo into a local folder named the same way: `trino`. This, however, doesn't work when an engineer needs to do a second checkout, or wants to make a backup of the repo for whatever purposes. The build and tests should not assume any particular name of the folder the repo is checked out into.
raunaqmorarka
approved these changes
Mar 11, 2023
| return workingDir.resolve("testing/trino-tests"); | ||
| default: | ||
| throw new IllegalStateException("This class must be executed from trino-tests or Trino source directory"); | ||
| if (isDirectory(workingDir.resolve(".git"))) { |
There was a problem hiding this comment.
I wonder if we should check for existence of .gitignore file instead since that is part of the checked out source.
There was a problem hiding this comment.
you can have .gitignore at any level within the repo, but .git folder should be only one
findepi
deleted the
findepi/don-t-enforce-top-level-repo-name-in-basecostbasedplantest-400066
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engineers will typically check out the repo into a local folder named the same way:
trino. This, however, doesn't work when an engineer needs to do a second checkout, or wants to make a backup of the repo for whatever purposes. The build and tests should not assume any particular name of the folder the repo is checked out into.