Avoid extra allocation in OrderByOperator#getOutput() #16447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Mar 8, 2023
| blocks[i] = nextPage.getBlock(outputChannels[i]); | ||
| } | ||
| return new Page(nextPage.getPositionCount(), blocks); | ||
| return nextPage.getColumns(outputChannels); |
There was a problem hiding this comment.
getColumns() calls wrapBlocksWithoutCopy(positionCount, blocks), while new Page(count, blocks) uses blocksCopyRequired = true. Have you analyzed the impact of that change in semantics?
There was a problem hiding this comment.
Yep, that's the intention behind this change. The Block[] array in the previous implementation was created locally (not shared anywhere else) but was created once and then immediately cloned by the page constructor unnecessarily. Now we only create a single copy of the blocks array inside of Page#getColumns which requires no additional copy (and makes the code a little cleaner).
|
@martint - ping for review / merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
OrderByOperator#getOutput()to usePage#getColumns(outputChannels)instead of building an array of output blocks itself, which avoids an extra allocation.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: