Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for table functions #16432

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

kasiafi
Copy link
Member

@kasiafi kasiafi commented Mar 8, 2023

Description

This change adds information about all types of arguments supported by table functions to both developer guide and user guide. Also, the developer guide is updated with the new way of executing table functions involving the operator.

Follow-up to: #15575

No release notes required. Only docs change.

@cla-bot cla-bot bot added the cla-signed label Mar 8, 2023
@kasiafi kasiafi force-pushed the 465DocumentTableFunctionsWithSources branch from 6fbd700 to f463789 Compare March 8, 2023 09:52
@github-actions github-actions bot added the docs label Mar 8, 2023
@kasiafi kasiafi requested review from mosabua and martint March 8, 2023 14:12
docs/src/main/sphinx/develop/table-functions.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/develop/table-functions.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/develop/table-functions.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/develop/table-functions.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/functions/table.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/functions/table.rst Show resolved Hide resolved
docs/src/main/sphinx/functions/table.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/functions/table.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/functions/table.rst Outdated Show resolved Hide resolved
@kasiafi kasiafi force-pushed the 465DocumentTableFunctionsWithSources branch from f463789 to 9a12c35 Compare March 10, 2023 08:55
@kasiafi kasiafi force-pushed the 465DocumentTableFunctionsWithSources branch from 9a12c35 to ec61094 Compare March 10, 2023 10:42
@kasiafi
Copy link
Member Author

kasiafi commented Mar 10, 2023

@mosabua thanks for your review! I applied or answered comments. Ready for another round.

@kasiafi
Copy link
Member Author

kasiafi commented Mar 15, 2023

@mosabua could you please take another look?

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it another read. I think this is good to go.

@kasiafi kasiafi merged commit d08881b into trinodb:master Mar 17, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants