-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for table functions #16432
Merged
kasiafi
merged 6 commits into
trinodb:master
from
kasiafi:465DocumentTableFunctionsWithSources
Mar 17, 2023
Merged
Update documentation for table functions #16432
kasiafi
merged 6 commits into
trinodb:master
from
kasiafi:465DocumentTableFunctionsWithSources
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiafi
force-pushed
the
465DocumentTableFunctionsWithSources
branch
from
March 8, 2023 09:52
6fbd700
to
f463789
Compare
mosabua
reviewed
Mar 9, 2023
mosabua
requested changes
Mar 9, 2023
kasiafi
force-pushed
the
465DocumentTableFunctionsWithSources
branch
from
March 10, 2023 08:55
f463789
to
9a12c35
Compare
kasiafi
force-pushed
the
465DocumentTableFunctionsWithSources
branch
from
March 10, 2023 10:42
9a12c35
to
ec61094
Compare
@mosabua thanks for your review! I applied or answered comments. Ready for another round. |
@mosabua could you please take another look? |
mosabua
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it another read. I think this is good to go.
losipiuk
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds information about all types of arguments supported by table functions to both developer guide and user guide. Also, the developer guide is updated with the new way of executing table functions involving the operator.
Follow-up to: #15575
No release notes required. Only docs change.