Support coercing char types of different lengths in hive #16402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
praveen/char_coercion_test
branch
3 times, most recently
from
620f356 to
5c8eb0b
Compare
Praveen2112
requested review from
ebyhr,
skrzypo987,
huberty89,
kokosing,
phd3,
findepi and
atanasenko
Praveen2112
changed the title
Praveen2112
changed the title
ebyhr
approved these changes
Mar 14, 2023
| @@ -372,6 +380,13 @@ public static boolean narrowerThan(VarcharType first, VarcharType second) | |||
| return first.getBoundedLength() < second.getBoundedLength(); | |||
| } | |||
|
|
|||
| public static boolean narrowerThan(CharType first, CharType second) | |||
There was a problem hiding this comment.
nit: We use "short" at least in io.trino.spi.type.Chars class. No requested change as there's the existing narrowerThan method.
Suggested change
| public static boolean narrowerThan(CharType first, CharType second) | |
| public static boolean shorterThan(CharType first, CharType second) |
| @@ -84,6 +85,9 @@ private boolean canCoerce(HiveType fromHiveType, HiveType toHiveType, HiveTimest | |||
| if (fromType instanceof DecimalType) { | |||
| return toType instanceof DecimalType || toHiveType.equals(HIVE_FLOAT) || toHiveType.equals(HIVE_DOUBLE); | |||
| } | |||
| if (fromType instanceof CharType) { | |||
There was a problem hiding this comment.
nit: Move to before if (toType instanceof VarcharType) {.
Praveen2112
force-pushed
the
praveen/char_coercion_test
branch
from
5c8eb0b to
a04a5c9
Compare
|
@ebyhr AC |
skrzypo987
approved these changes
Mar 16, 2023
| @@ -327,6 +334,12 @@ else if (getHiveVersionMajor() == 3 && isFormat.test("orc")) { | |||
| .put("varchar_to_smaller_varchar", Arrays.asList( | |||
| "ab", | |||
| "\uD83D\uDCB0\uD83D\uDCB0")) | |||
| .put("char_to_bigger_char", Arrays.asList( | |||
There was a problem hiding this comment.
nit: if ImmutableList is not available then use List.of(). Arrays.asList is not cool anymore
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/BaseTestHiveCoercion.java
Show resolved
Hide resolved
kokosing
approved these changes
Mar 16, 2023
Praveen2112
force-pushed
the
praveen/char_coercion_test
branch
from
a04a5c9 to
47fbca7
Compare
|
@skrzypo987 AC |
Praveen2112
force-pushed
the
praveen/char_coercion_test
branch
3 times, most recently
from
db48677 to
ecc9895
Compare
For list with null values we still use Arrays#asList
Praveen2112
force-pushed
the
praveen/char_coercion_test
branch
from
ecc9895 to
8542ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for coercing from
Additional context and related issues
Similar to #5530
Release notes
(x) Release notes are required, with the following suggested text: