Set DriverYieldSignal in Driver#close() #16395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhimondr
approved these changes
Mar 7, 2023
core/trino-main/src/main/java/io/trino/operator/DriverYieldSignal.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
driver-yield-on-close
branch
from
04fb20e to
beef7d9
Compare
Attempts to speed up driver termination by setting the DriverYieldSignal as part of Driver#close() so that long running in-memory operations that don't respond to interrupts can detect task termination sooner.
pettyjamesm
force-pushed
the
driver-yield-on-close
branch
from
beef7d9 to
d6f47eb
Compare
|
Test failure seems to be caused by #16406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempts to speed up driver termination by setting the
DriverYieldSignalas part ofDriver#close()so that long running in-memory operations that don't respond to interrupts can detect task termination sooner.Additional context and related issues
Extracted from #15478 since it applies cleanly and improves the speed of driver threads stopping when tasks are canceled or aborted even when that isn't reflected in task status.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: