-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deserialize partition value by physical name for Delta connector #16388
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Schutte.
|
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
6e747b0
to
12a6c5f
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
12a6c5f
to
40760f5
Compare
@ebyhr Is this PR ready for merging or is there still something missing? |
/test-with-secrets sha=40760f5ff40a0cc1a41228e2e3d5b73389222b95 |
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4382799260 |
40760f5
to
caf0df0
Compare
/test-with-secrets sha=caf0df00ba179e6f5c0077ac42d8f7751246130d |
Description
When supplying a partition predicate on a Delta table which has column mapping set to 'name' to the
DeltaLakeSplitManager
the values of the partition predicate are not resolved to the physical name but the name of the column.Additional context and related issues
Without the above patch, any query with a where clause on the partition column will fail with the following stack-trace:
https://pastebin.com/PcK3WG8P
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: