BaseJdbcClient and FTE test cleanup #16379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Mar 6, 2023
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
hashhar
force-pushed
the
hashhar/fte-guice
branch
from
867ad3c to
78674c8
Compare
hashhar
changed the title
kokosing
reviewed
Mar 6, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
Having multiple variants with different argument orders makes it difficult to use.
hashhar
force-pushed
the
hashhar/fte-guice
branch
from
78674c8 to
ff78e02
Compare
|
PTAL again @kokosing |
wendigo
reviewed
Mar 20, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
vlad-lyutenko
approved these changes
Mar 20, 2023
losipiuk
approved these changes
Mar 20, 2023
Some connector's underlying systems don't handle high concurrency very well and it's useful to limit the concurrency of the test in order to avoid flakiness or failures.
hashhar
force-pushed
the
hashhar/fte-guice
branch
from
ff78e02 to
41c27eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release notes
(x) This is not user-visible or docs only and no release notes are required.