Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language codes from external URLs #16314

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

blvckcoffee
Copy link
Member

Description

  • Removes language codes from external URLs in multiple files to better accommodate a global audience

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks.

@github-actions github-actions bot added the docs label Mar 1, 2023
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflict

@blvckcoffee blvckcoffee force-pushed the jj/remove-url-lang-codes branch 2 times, most recently from ba989fd to 722d1a4 Compare March 6, 2023 17:21
@mosabua
Copy link
Member

mosabua commented Mar 6, 2023

@electrum this is ready now

@ebyhr
Copy link
Member

ebyhr commented Mar 14, 2023

There's another conflict. Could you rebase on master again?

@blvckcoffee blvckcoffee force-pushed the jj/remove-url-lang-codes branch from 722d1a4 to a4de074 Compare March 14, 2023 18:28
@mosabua
Copy link
Member

mosabua commented Mar 17, 2023

@ebyhr can you please merge?

@ebyhr ebyhr merged commit 9defc02 into trinodb:master Mar 17, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants