Eagerly discard FileSingleStreamSpiller encryption keys #16307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
force-pushed
the
discard-spill-key-eagerly
branch
from
475c52d to
c1c3700
Compare
JunhyungSong
approved these changes
Feb 28, 2023
pettyjamesm
force-pushed
the
discard-spill-key-eagerly
branch
from
c1c3700 to
bd84691
Compare
pettyjamesm
force-pushed
the
discard-spill-key-eagerly
branch
from
bd84691 to
3784ba3
Compare
electrum
approved these changes
Mar 7, 2023
|
@electrum - build is green, let me know if you need anything else before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids retaining spill to disk encryption keys as part of
FileSingleStreamSpillerinstances after they are closed or the final read-back begins, making them unreachable and eligible for garbage collection sooner.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: