Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version requirement for Hudi connector #16246

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add version requirement for Hudi connector #16246

merged 1 commit into from
Mar 22, 2023

Conversation

blvckcoffee
Copy link
Member

Description

  • Adds a minimum version number to the Requirements section for the Hudi connector

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 23, 2023
@blvckcoffee blvckcoffee requested a review from mosabua February 23, 2023 20:43
mosabua
mosabua reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text and wording wise this is fine. The version number was determined by the version of Hudi used for tests. This might be correct and is the best we can tell.

I would love to get input from @findepi @electrum or @ebyhr to confirm or clarify.

@mosabua
Copy link
Member

mosabua commented Feb 23, 2023

@raunaqmorarka @skrzypo987 or @ksobolew might also have insights

@tooptoop4
Copy link
Contributor

@codope I thought lower was ok?

@ebyhr ebyhr force-pushed the jj/hudi-version-requirement branch from e4c40db to e39d067 Compare March 22, 2023 04:45
@ebyhr ebyhr merged commit 7bb2f19 into trinodb:master Mar 22, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 22, 2023
@colebow colebow mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua left review comments

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
411
Development

Successfully merging this pull request may close these issues.
4 participants
@blvckcoffee @mosabua @tooptoop4 @ebyhr