Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show stats in EXPLAIN/EXPLAIN ANALYZE with partial aggregation #16201

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

Dith3r
Copy link
Member

@Dith3r Dith3r commented Feb 21, 2023

Description

Show stats for final aggregation in EXPLAIN/EXPLAIN ANALYZE when partial aggregation is present.

Additional context and related issues

Fixes #6323

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# General
* Improve output of EXPLAIN queries to show statistics when the query contains aggregations. ({issue}`16201`)

@Dith3r Dith3r force-pushed the ke/partial-stats branch 2 times, most recently from 5548429 to 63a45a1 Compare February 23, 2023 14:06
@Dith3r Dith3r marked this pull request as ready for review February 27, 2023 12:33
@Dith3r Dith3r requested a review from sopel39 February 27, 2023 12:33
@Dith3r Dith3r requested a review from raunaqmorarka February 28, 2023 11:28
@github-actions github-actions bot added the hive Hive connector label Feb 28, 2023
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % minor changes

@Dith3r Dith3r force-pushed the ke/partial-stats branch from 940b970 to 7404690 Compare March 1, 2023 07:42
@Dith3r Dith3r force-pushed the ke/partial-stats branch from 7404690 to ee2041a Compare March 1, 2023 14:00
@raunaqmorarka raunaqmorarka merged commit a22f24c into trinodb:master Mar 2, 2023
@github-actions github-actions bot added this to the 409 milestone Mar 2, 2023
@Dith3r Dith3r deleted the ke/partial-stats branch March 27, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector
Development

Successfully merging this pull request may close these issues.

Show stats for aggregation queries in SHOW STATS
5 participants