-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show stats in EXPLAIN/EXPLAIN ANALYZE with partial aggregation #16201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Feb 21, 2023
Dith3r
force-pushed
the
ke/partial-stats
branch
2 times, most recently
from
February 23, 2023 14:06
5548429
to
63a45a1
Compare
core/trino-main/src/main/java/io/trino/cost/PartialAggregationStatsRule.java
Outdated
Show resolved
Hide resolved
Dith3r
force-pushed
the
ke/partial-stats
branch
from
February 28, 2023 08:22
63a45a1
to
90eb127
Compare
lukasz-stec
reviewed
Feb 28, 2023
core/trino-main/src/main/java/io/trino/cost/AggregationStatsRule.java
Outdated
Show resolved
Hide resolved
Dith3r
force-pushed
the
ke/partial-stats
branch
from
February 28, 2023 09:03
90eb127
to
8cf5f6f
Compare
Dith3r
force-pushed
the
ke/partial-stats
branch
from
February 28, 2023 11:30
8cf5f6f
to
940b970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % minor changes
core/trino-main/src/main/java/io/trino/cost/AggregationStatsRule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/cost/AggregationStatsRule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/cost/AggregationStatsRule.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/tpch/TestTpchLocalStats.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/cost/AggregationStatsRule.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
approved these changes
Mar 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show stats for final aggregation in EXPLAIN/EXPLAIN ANALYZE when partial aggregation is present.
Additional context and related issues
Fixes #6323
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: