-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a metadata table showing commits in Hudi connector #16181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add documentation about the new system table in |
findinpath
reviewed
Feb 20, 2023
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/TimelineTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/TimelineTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiSystemTables.java
Outdated
Show resolved
Hide resolved
albericgenius
force-pushed
the
snapshots
branch
from
February 21, 2023 06:12
7edcb0a
to
23cdec5
Compare
There is UI CI issue #16179, the failed test case is not relative to this PR. |
ebyhr
reviewed
Feb 22, 2023
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiSplitSource.java
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/TimelineTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/TimelineTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiTableName.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/TableType.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiSystemTables.java
Show resolved
Hide resolved
albericgenius
force-pushed
the
snapshots
branch
from
February 22, 2023 05:59
23cdec5
to
688a9ab
Compare
albericgenius
force-pushed
the
snapshots
branch
2 times, most recently
from
February 23, 2023 13:19
2c606a7
to
58ee60f
Compare
findinpath
reviewed
Feb 23, 2023
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/TimelineTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiUtil.java
Outdated
Show resolved
Hide resolved
albericgenius
force-pushed
the
snapshots
branch
from
February 24, 2023 13:23
58ee60f
to
e17bb3c
Compare
ebyhr
reviewed
Mar 3, 2023
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiSplitSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiUtil.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/TimelineTable.java
Outdated
Show resolved
Hide resolved
.../main/resources/docker/presto-product-tests/conf/environment/singlenode-hudi/hive.properties
Outdated
Show resolved
Hide resolved
...rino-product-tests/src/main/java/io/trino/tests/product/hudi/TestHudiSparkCompatibility.java
Outdated
Show resolved
Hide resolved
...rino-product-tests/src/main/java/io/trino/tests/product/hudi/TestHudiSparkCompatibility.java
Outdated
Show resolved
Hide resolved
...rino-product-tests/src/main/java/io/trino/tests/product/hudi/TestHudiSparkCompatibility.java
Show resolved
Hide resolved
.build()); | ||
this.types = tableMetadata.getColumns().stream().map(ColumnMetadata::getType).collect(toImmutableList()); | ||
HoodieTableMetaClient metaClient = buildTableMetaClient(configuration, hudiTable.getStorage().getLocation()); | ||
this.hudiInstants = metaClient.getActiveTimeline().getInstants().sorted(comparing(HoodieInstant::getTimestamp).reversed()).collect(toImmutableList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will materialize all active timelines in my understanding. It would be nice to avoid it for avoiding high memory usage.
albericgenius
force-pushed
the
snapshots
branch
from
March 10, 2023 10:54
10d8685
to
c3636ff
Compare
ebyhr
reviewed
Mar 14, 2023
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiUtil.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiUtil.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiUtil.java
Outdated
Show resolved
Hide resolved
...rino-product-tests/src/main/java/io/trino/tests/product/hudi/TestHudiSparkCompatibility.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiSplitSource.java
Show resolved
Hide resolved
albericgenius
force-pushed
the
snapshots
branch
from
March 14, 2023 07:35
c3636ff
to
bbd5989
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #16149
Release notes
(x) Release notes are required, with the following suggested text: