Support writing NUMERIC and BIGNUMERIC types in BigQuery #16145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-lyutenko
commented
Feb 16, 2023
| // TODO https://github.com/trinodb/trino/issues/13741 Add support for decimal, time, timestamp with time zone, geography, map type | ||
| // TODO https://github.com/trinodb/trino/issues/13741 Add support for time, timestamp with time zone, geography, map type | ||
| if (type instanceof DecimalType) { | ||
| return readBigDecimal((DecimalType) type, block, position).toString(); |
There was a problem hiding this comment.
If we pass here as BigDecimal - it's rounded
ebyhr
reviewed
Feb 16, 2023
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryTypeUtils.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryTypeUtils.java
Show resolved
Hide resolved
|
/test-with-secrets sha=0065d9bc28865cdcdc3293ef388a3bc91e34be02 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4200631454 |
vlad-lyutenko
force-pushed
the
vlad-lyutenko/bignumeric-write-support
branch
from
0065d9b to
0b6b4fc
Compare
ebyhr
reviewed
Feb 17, 2023
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryTypeMapping.java
Outdated
Show resolved
Hide resolved
vlad-lyutenko
force-pushed
the
vlad-lyutenko/bignumeric-write-support
branch
from
0b6b4fc to
b6ceb4e
Compare
|
/test-with-secrets sha=b6ceb4e170fdc22655e770895f2d99bbe99da2e9 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4204994076 |
ebyhr
reviewed
Feb 18, 2023
| @@ -651,6 +713,11 @@ private DataSetup bigqueryCreateAndInsert(String tableNamePrefix) | |||
| return new CreateAndInsertDataSetup(getBigQuerySqlExecutor(), tableNamePrefix); | |||
| } | |||
|
|
|||
| private DataSetup bigqueryCreateAndTrinoInsert(String tableNamePrefix) | |||
| { | |||
| return new BigQueryCreateAndTrinoInsertDataSetup(new TrinoSqlExecutor(getQueryRunner(), getSession()), getBigQuerySqlExecutor(), tableNamePrefix); | |||
There was a problem hiding this comment.
BigQueryCreateAndTrinoInsertDataSetup isn't necessary:
return new CreateAndTrinoInsertDataSetup(getBigQuerySqlExecutor(), new TrinoSqlExecutor(getQueryRunner()), tableNamePrefix);
ebyhr
force-pushed
the
vlad-lyutenko/bignumeric-write-support
branch
from
b6ceb4e to
faa0870
Compare
ebyhr
force-pushed
the
vlad-lyutenko/bignumeric-write-support
branch
from
faa0870 to
3d88193
Compare
ebyhr
force-pushed
the
vlad-lyutenko/bignumeric-write-support
branch
from
3d88193 to
f44db01
Compare
ebyhr
approved these changes
Feb 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support writing NUMERIC and BIGNUMERIC types in BigQuery
Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text: