Support inserting into Delta Lake table having invariants #16136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajaks
reviewed
Feb 16, 2023
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorSmokeTest.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-invariant
branch
2 times, most recently
from
c5a6d11 to
8a04f92
Compare
ebyhr
force-pushed
the
ebi/delta-invariant
branch
from
8a04f92 to
90536cd
Compare
|
/test-with-secrets sha=90536cded9528a3748e25a2a8318833482b68a62 |
findepi
approved these changes
Mar 8, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorSmokeTest.java
Show resolved
Hide resolved
Comment on lines
-183
to
-184
| assertThatThrownBy(() -> query("INSERT INTO invariants VALUES(2)")) | ||
| .hasMessageContaining("Inserts are not supported for tables with delta invariants"); |
There was a problem hiding this comment.
How was that working? Shouldn't it be failing with table not found?
There was a problem hiding this comment.
Not sure if I understand the question correctly. The previous table name was invariants having column invariants and it existed, so it shouldn't throw table not found in my opinion. I renamed to a new table name with random suffix to avoid modifying shared tables.
ebyhr
force-pushed
the
ebi/delta-invariant
branch
from
90536cd to
c22bab7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support inserting into Delta Lake table having invariants
Release notes
(x) Release notes are required, with the following suggested text: