Fix create schema in glue catalog when username contains uppercase character #16123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrinoPrincipal sets the owner name in lowercase. So, while comparing the principal name with session user name ignore the case.
ebyhr
reviewed
Feb 15, 2023
| @@ -256,7 +256,7 @@ public Optional<TrinoPrincipal> getNamespacePrincipal(ConnectorSession session, | |||
| public void createNamespace(ConnectorSession session, String namespace, Map<String, Object> properties, TrinoPrincipal owner) | |||
| { | |||
| checkArgument(owner.getType() == PrincipalType.USER, "Owner type must be USER"); | |||
| checkArgument(owner.getName().equals(session.getUser()), "Explicit schema owner is not supported"); | |||
| checkArgument(owner.getName().equalsIgnoreCase(session.getUser()), "Explicit schema owner is not supported"); | |||
There was a problem hiding this comment.
@arhimondr @sopel39 Do you remember why TrinoPrincipal lowercase name argument #90? Username is case sensitive in my understanding #16124
|
Closing. This is a duplicate of #16124. |
|
Not a "duplicate" because the approach differs. I'm not sure if my PR is better than this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16116
TrinoPrincipal sets the owner name in lowercase always. So, while comparing the principal name
with session user name ignore the case.
Release notes
(X) Release notes are required, with the following suggested text: