Remove limits on dynamic-filtering.large-*.max-size-per-driver #16110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhimondr
approved these changes
Feb 14, 2023
core/trino-main/src/main/java/io/trino/operator/DynamicFilterSourceOperator.java
Show resolved
Hide resolved
With memory accounting added to DynamicFilterSourceOperator there is no longer a reason to put a limit on the max size per driver allowed in config.
raunaqmorarka
force-pushed
the
remove-max-config-limit
branch
from
155d997 to
d18dbb8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented memory accounting in DynamicFilterSourceOperator.
With memory accounting added to DynamicFilterSourceOperator there
is no longer a reason to put a limit on the max size per driver
allowed in config.
Additional context and related issues
Fixes #16100
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: