Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify predicates involving year function #16106

Merged
merged 1 commit into from
Mar 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@
import io.trino.sql.planner.iterative.rule.UnwrapDateTruncInComparison;
import io.trino.sql.planner.iterative.rule.UnwrapRowSubscript;
import io.trino.sql.planner.iterative.rule.UnwrapSingleColumnRowInApply;
import io.trino.sql.planner.iterative.rule.UnwrapYearInComparison;
import io.trino.sql.planner.iterative.rule.UseNonPartitionedJoinLookupSource;
import io.trino.sql.planner.optimizations.AddExchanges;
import io.trino.sql.planner.optimizations.AddLocalExchanges;
Expand Down Expand Up @@ -365,6 +366,7 @@ public PlanOptimizers(
.addAll(new PushCastIntoRow().rules())
.addAll(new UnwrapCastInComparison(plannerContext, typeAnalyzer).rules())
.addAll(new UnwrapDateTruncInComparison(plannerContext, typeAnalyzer).rules())
.addAll(new UnwrapYearInComparison(plannerContext, typeAnalyzer).rules())
.addAll(new RemoveDuplicateConditions(metadata).rules())
.addAll(new CanonicalizeExpressions(plannerContext, typeAnalyzer).rules())
.addAll(new RemoveRedundantDateTrunc(plannerContext, typeAnalyzer).rules())
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,229 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.trino.sql.planner.iterative.rule;

import com.google.common.annotations.VisibleForTesting;
import io.trino.Session;
import io.trino.spi.type.LongTimestamp;
import io.trino.spi.type.TimestampType;
import io.trino.spi.type.TimestampWithTimeZoneType;
import io.trino.spi.type.Type;
import io.trino.sql.PlannerContext;
import io.trino.sql.planner.ExpressionInterpreter;
import io.trino.sql.planner.LiteralEncoder;
import io.trino.sql.planner.NoOpSymbolResolver;
import io.trino.sql.planner.TypeAnalyzer;
import io.trino.sql.planner.TypeProvider;
import io.trino.sql.tree.BetweenPredicate;
import io.trino.sql.tree.Cast;
import io.trino.sql.tree.ComparisonExpression;
import io.trino.sql.tree.Expression;
import io.trino.sql.tree.ExpressionTreeRewriter;
import io.trino.sql.tree.FunctionCall;
import io.trino.sql.tree.IsNotNullPredicate;
import io.trino.sql.tree.IsNullPredicate;
import io.trino.sql.tree.NodeRef;
import io.trino.sql.tree.NotExpression;
import io.trino.sql.tree.NullLiteral;

import java.time.LocalDate;
import java.time.LocalDateTime;
import java.util.Map;

import static com.google.common.collect.Iterables.getOnlyElement;
import static io.trino.metadata.ResolvedFunction.extractFunctionName;
import static io.trino.spi.type.BooleanType.BOOLEAN;
import static io.trino.spi.type.DateType.DATE;
import static io.trino.spi.type.Timestamps.MICROSECONDS_PER_SECOND;
import static io.trino.sql.ExpressionUtils.or;
import static io.trino.sql.analyzer.TypeSignatureTranslator.toSqlType;
import static io.trino.sql.tree.ComparisonExpression.Operator.GREATER_THAN;
import static io.trino.sql.tree.ComparisonExpression.Operator.GREATER_THAN_OR_EQUAL;
import static io.trino.sql.tree.ComparisonExpression.Operator.LESS_THAN;
import static io.trino.sql.tree.ComparisonExpression.Operator.LESS_THAN_OR_EQUAL;
import static io.trino.type.DateTimes.PICOSECONDS_PER_MICROSECOND;
import static io.trino.type.DateTimes.scaleFactor;
import static java.lang.Math.multiplyExact;
import static java.lang.Math.toIntExact;
import static java.time.ZoneOffset.UTC;
import static java.time.temporal.TemporalAdjusters.lastDayOfYear;
import static java.util.Objects.requireNonNull;

/**
* Transforms a constant date/time expression t
* <pre>
* year(date_time) = t
* </pre>
* <p>
* into
* <pre>
* date_time BETWEEN (beginning of the year t) AND (end of the year t)
* </pre>
* <p>
*
* @see UnwrapCastInComparison
*/
public class UnwrapYearInComparison
extends ExpressionRewriteRuleSet
{
public UnwrapYearInComparison(PlannerContext plannerContext, TypeAnalyzer typeAnalyzer)
{
super(createRewrite(plannerContext, typeAnalyzer));
}

private static ExpressionRewriter createRewrite(PlannerContext plannerContext, TypeAnalyzer typeAnalyzer)
{
requireNonNull(plannerContext, "plannerContext is null");
requireNonNull(typeAnalyzer, "typeAnalyzer is null");

return (expression, context) -> unwrapYear(context.getSession(), plannerContext, typeAnalyzer, context.getSymbolAllocator().getTypes(), expression);
}

private static Expression unwrapYear(Session session,
PlannerContext plannerContext,
TypeAnalyzer typeAnalyzer,
TypeProvider types,
Expression expression)
{
return ExpressionTreeRewriter.rewriteWith(new Visitor(plannerContext, typeAnalyzer, session, types), expression);
}

private static class Visitor
extends io.trino.sql.tree.ExpressionRewriter<Void>
{
private final PlannerContext plannerContext;
private final TypeAnalyzer typeAnalyzer;
private final Session session;
private final TypeProvider types;
private final LiteralEncoder literalEncoder;

public Visitor(PlannerContext plannerContext, TypeAnalyzer typeAnalyzer, Session session, TypeProvider types)
{
this.plannerContext = requireNonNull(plannerContext, "plannerContext is null");
this.typeAnalyzer = requireNonNull(typeAnalyzer, "typeAnalyzer is null");
this.session = requireNonNull(session, "session is null");
this.types = requireNonNull(types, "types is null");
this.literalEncoder = new LiteralEncoder(plannerContext);
}

@Override
public Expression rewriteComparisonExpression(ComparisonExpression node, Void context, ExpressionTreeRewriter<Void> treeRewriter)
{
ComparisonExpression expression = (ComparisonExpression) treeRewriter.defaultRewrite((Expression) node, null);
return unwrapYear(expression);
}

// Simplify `year(d) ? value`
private Expression unwrapYear(ComparisonExpression expression)
{
// Expect year on the left side and value on the right side of the comparison.
// This is provided by CanonicalizeExpressionRewriter.
if (!(expression.getLeft() instanceof FunctionCall call) ||
!extractFunctionName(call.getName()).equals("year") ||
call.getArguments().size() != 1) {
return expression;
}

Map<NodeRef<Expression>, Type> expressionTypes = typeAnalyzer.getTypes(session, types, expression);

Expression argument = getOnlyElement(call.getArguments());
Type argumentType = expressionTypes.get(NodeRef.of(argument));

Object right = new ExpressionInterpreter(expression.getRight(), plannerContext, session, expressionTypes)
.optimize(NoOpSymbolResolver.INSTANCE);

if (right == null || right instanceof NullLiteral) {
return switch (expression.getOperator()) {
case EQUAL, NOT_EQUAL, LESS_THAN, LESS_THAN_OR_EQUAL, GREATER_THAN, GREATER_THAN_OR_EQUAL -> new Cast(new NullLiteral(), toSqlType(BOOLEAN));
case IS_DISTINCT_FROM -> new IsNotNullPredicate(argument);
};
}

if (right instanceof Expression) {
return expression;
}
if (argumentType instanceof TimestampWithTimeZoneType) {
// Cannot replace with a range due to how year operates on value's local date/time.
// I.e. unwrapping is possible only when values are all of some fixed zone and the zone is known.
return expression;
}
if (argumentType != DATE && !(argumentType instanceof TimestampType)) {
// e.g. year(INTERVAL) not handled here
return expression;
}

int year = toIntExact((Long) right);
return switch (expression.getOperator()) {
case EQUAL -> between(argument, argumentType, calculateRangeStartInclusive(year, argumentType), calculateRangeEndInclusive(year, argumentType));
case NOT_EQUAL -> new NotExpression(between(argument, argumentType, calculateRangeStartInclusive(year, argumentType), calculateRangeEndInclusive(year, argumentType)));
case IS_DISTINCT_FROM -> or(
new IsNullPredicate(argument),
new NotExpression(between(argument, argumentType, calculateRangeStartInclusive(year, argumentType), calculateRangeEndInclusive(year, argumentType))));
case LESS_THAN -> new ComparisonExpression(LESS_THAN, argument, toExpression(calculateRangeStartInclusive(year, argumentType), argumentType));
case LESS_THAN_OR_EQUAL -> new ComparisonExpression(LESS_THAN_OR_EQUAL, argument, toExpression(calculateRangeEndInclusive(year, argumentType), argumentType));
case GREATER_THAN -> new ComparisonExpression(GREATER_THAN, argument, toExpression(calculateRangeEndInclusive(year, argumentType), argumentType));
case GREATER_THAN_OR_EQUAL -> new ComparisonExpression(GREATER_THAN_OR_EQUAL, argument, toExpression(calculateRangeStartInclusive(year, argumentType), argumentType));
};
}

private BetweenPredicate between(Expression argument, Type type, Object minInclusive, Object maxInclusive)
{
return new BetweenPredicate(
argument,
toExpression(minInclusive, type),
toExpression(maxInclusive, type));
}

private Expression toExpression(Object value, Type type)
{
return literalEncoder.toExpression(session, value, type);
}
}

private static Object calculateRangeStartInclusive(int year, Type type)
{
if (type == DATE) {
LocalDate firstDay = LocalDate.ofYearDay(year, 1);
return firstDay.toEpochDay();
}
if (type instanceof TimestampType timestampType) {
long yearStartEpochSecond = LocalDateTime.of(year, 1, 1, 0, 0).toEpochSecond(UTC);
long yearStartEpochMicros = multiplyExact(yearStartEpochSecond, MICROSECONDS_PER_SECOND);
if (timestampType.isShort()) {
return yearStartEpochMicros;
}
return new LongTimestamp(yearStartEpochMicros, 0);
}
throw new UnsupportedOperationException("Unsupported type: " + type);
}

@VisibleForTesting
public static Object calculateRangeEndInclusive(int year, Type type)
{
if (type == DATE) {
LocalDate lastDay = LocalDate.ofYearDay(year, 1).with(lastDayOfYear());
return lastDay.toEpochDay();
}
if (type instanceof TimestampType timestampType) {
long nextYearStartEpochSecond = LocalDateTime.of(year + 1, 1, 1, 0, 0).toEpochSecond(UTC);
long nextYearStartEpochMicros = multiplyExact(nextYearStartEpochSecond, MICROSECONDS_PER_SECOND);
if (timestampType.isShort()) {
return nextYearStartEpochMicros - scaleFactor(timestampType.getPrecision(), 6);
}
int picosOfMicro = toIntExact(PICOSECONDS_PER_MICROSECOND - scaleFactor(timestampType.getPrecision(), 12));
return new LongTimestamp(nextYearStartEpochMicros - 1, picosOfMicro);
}
throw new UnsupportedOperationException("Unsupported type: " + type);
}
}
Loading