-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native OpenX JSON format #16073
Merged
Merged
Add native OpenX JSON format #16073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
openx-json
branch
5 times, most recently
from
February 26, 2023 01:25
c6f585e
to
cefba2d
Compare
electrum
approved these changes
Mar 11, 2023
...no-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/InvalidJsonException.java
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/openxjson/README.md
Outdated
Show resolved
Hide resolved
This was referenced Mar 29, 2023
For someone who searching the way to use OpenX JSON Serde, Just use OPENX_JSON for ‘format’ the table property. Those session properties introduced in this pr was removed somehow. |
cc @mosabua we should document this |
Linked PR in preceding comment is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add native implementation of the OpenX JSON SerDe (
org.openx.data.jsonserde.JsonSerDe
) with extensions. The exact behavior of this format is covered in the README.md inAdd native OpenX JSON format
commit.Documentation notes
This format implementation contains several extensions over the original PR as noted in the README file. This is a different approach than the other native implementations which strive for a bug-for-bug compatibility. I think we should summarize the major changes into the main documentations:
DECIMAL(P, S)
,CHAR(N)
,VARCHAR(N)
,VARBINARY
.These extensions are not in Hive and Spark, so any table that relies on these extensions may not be readable and/or writable in Hive and Spark. In this case, the user would simply change the column types in the Hive Metastore to a type supported by Hive and Spark.
Release notes