Fix bad parameter count in code generator when column uses double slots #15979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
reviewed
Feb 27, 2023
| @@ -354,7 +354,7 @@ else if (type == ConnectorSession.class) { | |||
| private static InvocationArgumentConvention getPreferredArgumentConvention(BytecodeNode argument, int argumentCount, boolean nullable) | |||
| { | |||
| // a Java function can only have 255 arguments, so if the count is low use block position or boxed nullable as they are more efficient | |||
| if (argumentCount <= 100) { | |||
| if (argumentCount <= 84) { | |||
There was a problem hiding this comment.
I assume this was chosed becuse 256 / 3 = 85.3. There are other parameters that can be added, like session. I would make this 64 instead, which leaves plenty of space for extra stuff.
There was a problem hiding this comment.
Yes, the number was calculated that way and I tested with the parameters counts around that threshold and all queries compiled correctly
zhaner08
commented
Mar 14, 2023
zhaner08
force-pushed
the
fix_double_slots_code_gen_issue
branch
from
6b7960b to
b08a3cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change [/pull/7014] was trying to fix a bad parameter count issue when there are too many parameters for code generators, and this change makes sure when there are 100 or below number of parameters, BLOCK_POSITION will not be used to prevent issues. However, 100 is not enough especially when it comes to double slots type like Long. Double slots for long plus a nullable flag will cause the number of parameters surpass the max of 255 and causing query compiler error. This change further limits it down so double slots types with number of parameters between 85 to 100 will not throw error
Additional context and related issues
/pull/7014
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text: