Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated SPI revapi exclusions #15863

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Remove outdated SPI revapi exclusions #15863

merged 1 commit into from
Jan 26, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented Jan 26, 2023 •
edited
Loading

Extracted from #15842

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jan 26, 2023
@cla-bot cla-bot bot added the cla-signed label Jan 26, 2023
djsstarburst
djsstarburst approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@djsstarburst djsstarburst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up for the Delete, Update and RowId method removal.

@findepi findepi merged commit a666673 into trinodb:master Jan 26, 2023
@findepi findepi deleted the findepi/remove-outdated-spi-revapi-exclusions-dfeb50 branch January 26, 2023 21:54
@github-actions github-actions bot added this to the 407 milestone Jan 27, 2023
@colebow colebow mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djsstarburst djsstarburst djsstarburst approved these changes

@sopel39 sopel39 sopel39 approved these changes

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@martint martint Awaiting requested review from martint

@ebyhr ebyhr Awaiting requested review from ebyhr

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
407
Development

Successfully merging this pull request may close these issues.
4 participants
@findepi @raunaqmorarka @sopel39 @djsstarburst