Implement Hive parquet bloomfilter prune test #15633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leetcode-1533
force-pushed
the
BloomFilterPruneTest
branch
from
b5d7d55 to
d85f10d
Compare
findinpath
reviewed
Jan 8, 2023
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
|
|
||
| JobConf jobConf = new JobConf(newEmptyConfiguration()); | ||
| jobConf.setEnum(WRITER_VERSION, PARQUET_1_0); | ||
| jobConf.setBoolean(BLOOM_FILTER_ENABLED, true); |
There was a problem hiding this comment.
nit: Let's enable the bloom filter only for columnName and not for all columns
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
| jobConf.setEnum(WRITER_VERSION, PARQUET_1_0); | ||
| jobConf.setBoolean(BLOOM_FILTER_ENABLED, true); | ||
|
|
||
| ParquetTester.writeParquetColumn( |
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Show resolved
Hide resolved
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
...n/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestHiveParquetWithBloomFilters.java
Outdated
Show resolved
Hide resolved
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
@leetcode-1533, are you still working on this PR? If not we can close it for now and reopen it later. Let me know! Thanks! |
raunaqmorarka
force-pushed
the
BloomFilterPruneTest
branch
from
d85f10d to
b5437f0
Compare
raunaqmorarka
force-pushed
the
BloomFilterPruneTest
branch
from
b5437f0 to
64d7097
Compare
raunaqmorarka
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Hive parquet bloomfilter prune test.
Additional context and related issues
This unit test can help to verify whether enabling hive parquet's parquet.use-bloom-filter option will help Trino to load fewer blocks(row-groups)
More details: #14428 (comment)
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: