Use createTestingFileHiveMetastore method in tests #15468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
added
the
no-release-notes
ebyhr
force-pushed
the
ebi/iceberg-cleanup-file-metastore-test
branch
3 times, most recently
from
b693a21 to
528fa9e
Compare
|
CI hit #14248 |
findinpath
reviewed
Dec 20, 2022
| HiveMetastore metastore = new FileHiveMetastore( | ||
| new NodeVersion("testversion"), | ||
| HDFS_ENVIRONMENT, | ||
| HIDE_DELTA_LAKE_TABLES_IN_ICEBERG, |
There was a problem hiding this comment.
potential follow-up: HIDE_DELTA_LAKE_TABLES_IN_ICEBERG is used now only in:
IcebergHiveMetastoreCatalogModuleIcebergFileMetastoreCatalogModule
We can probably drop this constant and replace it with false in the bindings.
| new FileHiveMetastoreConfig() | ||
| .setCatalogDirectory(baseDir.toURI().toString()) | ||
| .setMetastoreUser("test")); | ||
| HiveMetastore hiveMetastore = createTestingFileHiveMetastore(baseDir); |
There was a problem hiding this comment.
can be inlined in the subsequent line where metastore is being initialized.
| new FileHiveMetastoreConfig() | ||
| .setCatalogDirectory(dataDirectory.toFile().toURI().toString()) | ||
| .setMetastoreUser("test")); | ||
| HiveMetastore metastore = createTestingFileHiveMetastore(dataDirectory.toFile()); |
There was a problem hiding this comment.
Inline in the next statement
| @@ -36,6 +26,7 @@ | |||
|
|
|||
| import java.nio.file.Path; | |||
|
|
|||
| import static io.trino.plugin.hive.metastore.file.FileHiveMetastore.createTestingFileHiveMetastore; | |||
There was a problem hiding this comment.
pre-existing/ follow-up: This class tests the situation where the file metastore is being shared and not the hive metastore. I'd advocate for renaming the class to TestSharedFileMetastore.
There was a problem hiding this comment.
Please feel free to send the follow-up PR.
ebyhr
force-pushed
the
ebi/iceberg-cleanup-file-metastore-test
branch
from
b1d8ba5 to
3fd90af
Compare
ebyhr
force-pushed
the
ebi/iceberg-cleanup-file-metastore-test
branch
from
3fd90af to
cc40061
Compare
findepi
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
createTestingFileHiveMetastoremethod in testsRelease notes
(x) This is not user-visible or docs only and no release notes are required.