Add an example JDBC connector plugin #15004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
force-pushed
the
dev-guide-jdbc
branch
from
b89a8ce to
80da0fb
Compare
kokosing
reviewed
Feb 2, 2023
kokosing
reviewed
Feb 3, 2023
plugin/trino-example-jdbc/src/test/java/io/trino/plugin/example/TestExampleQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-example-jdbc/src/test/java/io/trino/plugin/example/ExampleQueryRunner.java
Outdated
Show resolved
Hide resolved
plugin/trino-example-jdbc/src/test/java/io/trino/plugin/example/ExampleQueryRunner.java
Show resolved
Hide resolved
nineinchnick
force-pushed
the
dev-guide-jdbc
branch
9 times, most recently
from
55be220 to
a103eda
Compare
nineinchnick
force-pushed
the
dev-guide-jdbc
branch
from
a103eda to
22d750a
Compare
kokosing
approved these changes
Mar 27, 2023
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an example JDBC plugin and a new section in the docs. My main intention is to have a docs section where we could start capturing nuances of correct type mapping (rounding, validation, etc.).
This is not related to #2910
Non-technical explanation
An example JDBC plugin can be used as an example when creating a new third-party JDBC connector.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: