-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fault tolerant execution for SqlServer connector #14730
Conversation
650dabd
to
421df72
Compare
Update the documentation at |
<configuration> | ||
<threadCount>4</threadCount> | ||
<includes> | ||
<include>**/io/trino/faulttolerant/sqlserver/Test*.java</include> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update excludes section above:
<excludes>
<exclude>**/io/trino/faulttolerant/delta/Test*.java</exclude>
<exclude>**/io/trino/faulttolerant/hive/Test*.java</exclude>
<exclude>**/io/trino/faulttolerant/iceberg/Test*.java</exclude>
<exclude>**/io/trino/faulttolerant/mysql/Test*.java</exclude>
<exclude>**/io/trino/faulttolerant/postgresql/Test*.java</exclude>
</excludes>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Yeah - also add mysql and postgres there. In a separate commit (first in this PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo ignore
Also see failing tests - you need to adjust dependencies in pom. |
421df72
to
d05f782
Compare
d05f782
to
e625b93
Compare
Description
This pr enables fault tolerant execution for the SqlServer connector. It builds on the work done in my previous PR, which is why these changes are so minimal. The main change is passing
true
to the SqlServerClient'ssuper
constructor'ssupportsRetries
parameter.Non-technical explanation
This enables FTE for SqlServer and adds fault tolerance tests for the same.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text:
Enables fault tolerant execution on SqlServer connector.