Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default value for task.concurrency in docs #14699

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Update default value for task.concurrency in docs #14699

merged 1 commit into from
Oct 20, 2022

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Oct 20, 2022 •
edited
Loading

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 20, 2022
@github-actions github-actions bot added the docs label Oct 20, 2022
@sopel39 sopel39 requested a review from raunaqmorarka October 20, 2022 09:02
mosabua
mosabua requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are updating it .. lets make it clear what actually happens..

docs/src/main/sphinx/admin/properties-task.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/admin/properties-task.rst Outdated Show resolved Hide resolved
@sopel39 sopel39 requested a review from mosabua October 20, 2022 16:37
mosabua
mosabua approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a bit on the mathematical/terse side of things but in line with some of the others and clear enough. Lets ship it.

@sopel39 sopel39 merged commit e3cae54 into trinodb:master Oct 20, 2022
@sopel39 sopel39 deleted the ks/update_default branch October 20, 2022 20:03
@github-actions github-actions bot added this to the 401 milestone Oct 20, 2022
@colebow colebow mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@mosabua mosabua mosabua approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
401
Development

Successfully merging this pull request may close these issues.
3 participants
@sopel39 @mosabua @raunaqmorarka