Don't run testTrinoPreservesReaderAndWriterVersions in Databricks 7.3 #14687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Oct 19, 2022
| @@ -264,7 +264,7 @@ public void testTrinoAlterTablePreservesTableMetadata() | |||
| } | |||
| } | |||
|
|
|||
| @Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS}) | |||
| @Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_EXCLUDE_73, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS}) | |||
There was a problem hiding this comment.
Version 7.3 doesn't support delta.minReaderVersion and delta.minWriterVersion table properties. It causes query failure.
I will take a look if we shouldn't write those properties when existing tables don't have those properties.
io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: [Databricks][DatabricksJDBCDriver](500051) ERROR processing query/statement. Error Code: 0, SQL state: Error running query: org.apache.spark.sql.AnalysisException: Unknown configuration was specified: delta.minWriterVersion;, Query: CREATE TABLE default.test_trino_preserves_versions_vtizu3eknquk (col int) USING DELTA LOCATION 's3://trino-ci-test/databricks-compatibility-test-test_trino_preserves_versions_vtizu3eknquk'TBLPROPERTIES ('delta.minReaderVersion'='1', 'delta.minWriterVersion'='1', 'delta.checkpointInterval' = 1).
There was a problem hiding this comment.
Thanks for the explanation. Can it be captured as a code comment?
Merged
findepi
approved these changes
Oct 20, 2022
ebyhr
force-pushed
the
ebi/delta-fix-test
branch
from
3cb2431 to
9169110
Compare
ebyhr
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't run testTrinoPreservesReaderAndWriterVersions in Databricks 7.3
CI was green because suite-delta-lake-databricks didn't run since #10984 (#14662 fixes the issue)
Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.