Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase writer count in tests #14660

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Increase writer count in tests #14660

merged 1 commit into from
Oct 21, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 17, 2022 •
edited
Loading

@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Oct 17, 2022
@cla-bot cla-bot bot added the cla-signed label Oct 17, 2022
@findepi findepi mentioned this pull request Oct 17, 2022
Closed
sopel39
sopel39 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably tests will fail. Also mind #14553 (loosely related PR)

@findepi
Copy link
Member Author

findepi commented Oct 17, 2022

probably tests will fail.

yeah...

@findepi
Copy link
Member Author

findepi commented Oct 17, 2022

CI trino-main #14618

@findepi findepi force-pushed the findepi/increase-writer-count-in-tests-8b2b86 branch 2 times, most recently from 484de4c to 06c10f9 Compare October 17, 2022 09:13
@sopel39
Copy link
Member

sopel39 commented Oct 19, 2022

@findepi could you rebase?
#14636 and #14516 should be fixed on master

@findepi
Increase writer count in tests
8317cf8 
Ensure writer concurrency is test covered by default. Some bugs were not
noticed because of writer count defaulting to 1.
@findepi findepi force-pushed the findepi/increase-writer-count-in-tests-8b2b86 branch from 06c10f9 to 8317cf8 Compare October 19, 2022 12:22
@findepi
Copy link
Member Author

findepi commented Oct 19, 2022

@sopel39 rebased 🫡

@sopel39 sopel39 merged commit 0657345 into trinodb:master Oct 21, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 21, 2022
@findepi findepi deleted the findepi/increase-writer-count-in-tests-8b2b86 branch October 24, 2022 12:43
@colebow colebow mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopel39 sopel39 sopel39 approved these changes

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@djsstarburst djsstarburst Awaiting requested review from djsstarburst

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry test
Milestone
401
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @sopel39 @raunaqmorarka