Introduce constants to BaseJdbcConfig #14657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangjiangling
changed the title
tangjiangling
added
the
no-release-notes
findepi
reviewed
Oct 17, 2022
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestBaseJdbcConfig.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Oct 17, 2022
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestBaseJdbcConfig.java
Outdated
Show resolved
Hide resolved
tangjiangling
force-pushed
the
introduce-constants
branch
from
5f48765 to
3f6f2ac
Compare
|
Reverted and squashed commits. |
hashhar
approved these changes
Oct 18, 2022
...in/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestJdbcCachingConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
The configuration `metadata.cache-ttl` and `metadata.cache-maximum-size` are used in the exception message of `BaseJdbcConfig#validate`, so it is better to use constants to avoid the problem that the configuration is not synchronized with the exception message.
tangjiangling
force-pushed
the
introduce-constants
branch
from
3f6f2ac to
2686fdf
Compare
|
AC |
hashhar
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The configuration
metadata.cache-ttlandmetadata.cache-maximum-sizeare used in the exception message of
BaseJdbcConfig#validate, so it isbetter to use constants to avoid the problem that the configuration is
not synchronized with the exception message.
Release notes
(x) This is not user-visible or docs only and no release notes are required.