Improve type mapping documentation for Kafka connector #14646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlblessing
force-pushed
the
tb/kafka-type-mapping-redux
branch
from
3bee46d to
883ec52
Compare
jhlodin
approved these changes
Oct 20, 2022
ebyhr
reviewed
Oct 21, 2022
| @@ -1164,7 +1174,7 @@ For ``TIMESTAMP WITH TIME ZONE`` and ``TIME WITH TIME ZONE`` data types, if time | |||
| be used as Trino value. Otherwise result time zone will be set to ``UTC``. | |||
|
|
|||
| ``avro`` decoder | |||
| ^^^^^^^^^^^^^^^^ | |||
| """""""""""""""" | |||
There was a problem hiding this comment.
Could you use same naming between decoder and encoder?
There was a problem hiding this comment.
@ebyhr thank you for your review
tlblessing
force-pushed
the
tb/kafka-type-mapping-redux
branch
from
883ec52 to
36b3aac
Compare
jhlodin
approved these changes
Oct 24, 2022
ebyhr
approved these changes
Oct 26, 2022
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a type mapping section. Relo SQL Support to bottom of topic for consistency.
Original PR that I had to close: #14147