Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase startup attempts to 3 for Pinot containers #14630

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Oct 14, 2022

Description

Hopefully, fixes #14546

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 14, 2022
@ebyhr ebyhr requested review from hashhar and findepi October 14, 2022 06:12
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to stress this PR?

@ebyhr
Copy link
Member Author

ebyhr commented Oct 14, 2022

This is rare issue and I couldn't find the failure ratio in my past stress tests. Let me merge and reopen the issue if necessary.

@ebyhr ebyhr merged commit a8f8cfd into trinodb:master Oct 14, 2022
@ebyhr ebyhr deleted the ebi/pinot-retry-init branch October 14, 2022 09:12
@github-actions github-actions bot added this to the 401 milestone Oct 14, 2022
@xiangfu0
Copy link
Contributor

Per my stress test, this one doesn't fully fix the issue: #14324

Sometimes the containers are not fully up before the tests kick-off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants