Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document hive.max-partitions-for-eager-load configuration property #14599

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

colebow
Copy link
Member

@colebow colebow commented Oct 12, 2022

Description

This adds docs for the config property added in #14225. Also a preliminary commit to reformat the table to a list-table, which is a functional no-op.

Non-technical explanation

Docs only.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Oct 12, 2022
@colebow colebow requested review from mosabua and arhimondr October 12, 2022 19:27
@colebow colebow changed the title Colebow/hive max partitions docs Add docs for hive.max-partitions-for-eager-load Oct 12, 2022
@colebow colebow requested a review from martint October 12, 2022 19:27
@colebow colebow changed the title Add docs for hive.max-partitions-for-eager-load Document hive.max-partitions-for-eager-load configuration property Oct 12, 2022
- The maximum number of partitions for a single table scan to haven loaded
eagerly on the coordinator. Certain optimizations are not possible
without eager loading.
- 100,000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

100000

* - ``hive.max-partitions-per-scan``
- Maximum number of partitions for a single table scan.
- 100,000
- 1,000,000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1000000

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with all other properties on this table, and this is more readable considering the number of zeroes.

docs/src/main/sphinx/connector/hive.rst Outdated Show resolved Hide resolved
@colebow colebow force-pushed the colebow/hive-max-partitions-docs branch from aac14ad to 03101be Compare October 12, 2022 19:49
@martint martint merged commit f935187 into trinodb:master Oct 12, 2022
@martint
Copy link
Member

martint commented Oct 12, 2022

Tested locally

@github-actions github-actions bot added the docs label Oct 12, 2022
@colebow colebow deleted the colebow/hive-max-partitions-docs branch October 27, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants