Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse Procedures helper from plugin toolkit #14593

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Reuse Procedures helper from plugin toolkit #14593

merged 3 commits into from
Oct 15, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 12, 2022

No description provided.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Oct 12, 2022
@findepi findepi requested a review from krvikash October 12, 2022 13:24
@cla-bot cla-bot bot added the cla-signed label Oct 12, 2022
ebyhr
ebyhr approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for maven-checks failure.

Warning:  Unused declared dependencies found:
Warning:     com.google.errorprone:error_prone_annotations:jar:2.15.0:compile

@findepi findepi force-pushed the findepi/reuse-procedures-helper-from-plugin-toolkit-6c0299 branch from e09adc3 to 6bc4eaf Compare October 13, 2022 13:56
@findepi findepi merged commit da1eb94 into trinodb:master Oct 15, 2022
@findepi findepi deleted the findepi/reuse-procedures-helper-from-plugin-toolkit-6c0299 branch October 15, 2022 21:27
@github-actions github-actions bot added this to the 401 milestone Oct 15, 2022
@colebow colebow mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krvikash krvikash krvikash approved these changes

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
401
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @ebyhr @krvikash