Clarify ConnectorMetadata listing when schema name not found #14592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's important to require that `listTables`, `listViews` and `listMaterializedViews` do not fail when asked to list relations from a schema that does not exist. This is because schema existence cannot be ensured in a concurrent environment, i.e. a schema could have just been deleted concurrently. Lack of such assumptions for these methods would make predicate pushdown for tables like `system.jdbc.tables` impossible to do properly.
findepi
added
the
no-release-notes
losipiuk
approved these changes
Oct 12, 2022
hashhar
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
There are already lot of non-compliant ConnectorMetadata impls today in this case.
Is this part of some larger effort or just explicitly documenting expectations of the engine?
I can create some issues for the non-compliant ones accordingly.
LGTM % my question
indeed, i see 6 build failures
no larger effort. |
findepi
deleted the
findepi/clarify-connectormetadata-listing-when-schema-name-not-found-f08319
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important to require that
listTables,listViewsandlistMaterializedViewsdo not fail when asked to list relations from a schema that does not exist. This is because schema existence cannot be ensured in a concurrent environment, i.e. a schema could have just been deleted concurrently. Lack of such assumptions for these methods would make predicate pushdown for tables likesystem.jdbc.tablesimpossible to do properly.