Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyze iceberg table with an uppercase column name #14585

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

zhengxingmao
Copy link

@zhengxingmao zhengxingmao commented Oct 12, 2022

Description

Fix #14583

Non-technical explanation

Release notes

(*) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`14583`)

@cla-bot cla-bot bot added the cla-signed label Oct 12, 2022
@zhengxingmao zhengxingmao requested review from findepi and homar October 12, 2022 09:51
@zhengxingmao zhengxingmao changed the title Fix analyze iceberg table with an uppercase field error Fix analyze iceberg table with an uppercase column name error Oct 12, 2022
@zhengxingmao zhengxingmao force-pushed the fixAnalyzeIcebergTableError branch from 19ba93e to f8cae16 Compare October 12, 2022 10:48
@findepi
Copy link
Member

findepi commented Oct 12, 2022

@zhengxingmao thank you for your PR!

Would it be possible to have a test for this?

You will need Spark for creating a table with upper-case fields, you can add a test case to TestIcebergSparkCompatibility test class.

@zhengxingmao zhengxingmao force-pushed the fixAnalyzeIcebergTableError branch from f8cae16 to 9dec0c3 Compare October 13, 2022 01:45
@zhengxingmao zhengxingmao changed the title Fix analyze iceberg table with an uppercase column name error Fix analyze iceberg table with an uppercase column name Oct 13, 2022
@zhengxingmao zhengxingmao reopened this Oct 13, 2022
@findepi findepi force-pushed the fixAnalyzeIcebergTableError branch from 9dec0c3 to e2fec4f Compare October 13, 2022 12:47
@findepi findepi merged commit a0e06e4 into trinodb:master Oct 17, 2022
@findepi findepi mentioned this pull request Oct 17, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants