Upgrade minimum required and latest Cassandra version to 3.0 and 4.1 respectively #14562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krvikash
added
the
no-release-notes
findepi
approved these changes
Oct 11, 2022
hashhar
reviewed
Oct 11, 2022
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
ebyhr
approved these changes
Oct 11, 2022
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
ebyhr
changed the title
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
from
2078a2a to
bef3825
Compare
krvikash
removed
the
no-release-notes
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
from
bef3825 to
0cfdfa0
Compare
|
Could you confirm CI failure of |
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
2 times, most recently
from
56fe522 to
eedfc8f
Compare
krvikash
changed the title
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
from
eedfc8f to
0a1495f
Compare
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
3 times, most recently
from
0813dfc to
fc93d0c
Compare
ebyhr
reviewed
Oct 20, 2022
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraConnectorTest.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,1794 @@ | |||
| # Cassandra storage config YAML | |||
There was a problem hiding this comment.
Could you put only required configuration likes cassandra-dse.yaml?
There was a problem hiding this comment.
Modified the file with the minimum configuration. Though I could not find any doc on the what are properties that are not required to start the Cassandra server.
With the current property set, Tests are passing.
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
2 times, most recently
from
f616f9a to
c900196
Compare
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
from
c900196 to
e5f4cdb
Compare
findepi
reviewed
Oct 25, 2022
plugin/trino-cassandra/src/test/resources/cu-cassandra-latest.yaml
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
from
e5f4cdb to
da8627b
Compare
krvikash
force-pushed
the
enable-test-in-cassandra-plugin
branch
from
da8627b to
fab2716
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14404
I am increasing the cassandra version for the test environment from 2.2 to 3.0. Minimum supported version is 3.0, see here and increasing the latest cassandra version to 4.1.
Both versions use different sets of properties, so added a separate file for the 4.1 version.
Non-technical explanation
NA
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text: