Split the Delta Lake product test suite per Databricks runtime #14549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
Oct 10, 2022
findepi
reviewed
Oct 10, 2022
.../src/main/java/io/trino/tests/product/launcher/suite/suites/SuiteDeltaLakeDatabricks104.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
split-databricks-product-test-suites
branch
from
3b5ce61 to
df673ce
Compare
findepi
reviewed
Oct 11, 2022
.../src/main/java/io/trino/tests/product/launcher/suite/suites/SuiteDeltaLakeDatabricks104.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Oct 11, 2022
hashhar
reviewed
Oct 11, 2022
findinpath
force-pushed
the
split-databricks-product-test-suites
branch
from
df673ce to
7c64a90
Compare
hashhar
reviewed
Oct 11, 2022
findinpath
force-pushed
the
split-databricks-product-test-suites
branch
from
7c64a90 to
49b07ed
Compare
hashhar
approved these changes
Oct 11, 2022
findinpath
force-pushed
the
split-databricks-product-test-suites
branch
from
4c5e181 to
24824a5
Compare
ebyhr
reviewed
Oct 17, 2022
|
@findinpath Could you rebase on upstream to resolve conflicts? |
findinpath
force-pushed
the
split-databricks-product-test-suites
branch
3 times, most recently
from
7f4eda6 to
524a081
Compare
|
CI hit #14391 |
findinpath
force-pushed
the
split-databricks-product-test-suites
branch
from
8889283 to
dae2ca9
Compare
findinpath
force-pushed
the
split-databricks-product-test-suites
branch
from
dae2ca9 to
a593830
Compare
ebyhr
approved these changes
Nov 2, 2022
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of running all the product tests on a suite doing the tests for Delta Lake on top of Databricks for all custer versions, use one suite for each Databricks cluster runtime to reduce the product test runtime.
Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: