Remove PlanMatchPattern join overloading by builder #14542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dith3r
changed the title
sopel39
reviewed
Oct 10, 2022
core/trino-main/src/test/java/io/trino/sql/planner/assertions/JoinMatchPatternBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/assertions/JoinMatchPatternBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/assertions/PlanMatchPattern.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/assertions/PlanMatchPattern.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Oct 10, 2022
core/trino-main/src/test/java/io/trino/sql/planner/TestPredicatePushdown.java
Outdated
Show resolved
Hide resolved
Dith3r
force-pushed
the
issues/5976
branch
2 times, most recently
from
601d33d to
9bf7347
Compare
sopel39
reviewed
Oct 13, 2022
There was a problem hiding this comment.
lgtm % comments.
@raunaqmorarka, @findepi or @kasiafi do you want to take a look?
core/trino-main/src/test/java/io/trino/sql/planner/AbstractPredicatePushdownTest.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/AbstractPredicatePushdownTest.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/TestDynamicFilter.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/assertions/JoinMatchPatternBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/assertions/JoinMatchPatternBuilder.java
Outdated
Show resolved
Hide resolved
Dith3r
force-pushed
the
issues/5976
branch
2 times, most recently
from
696f401 to
9ec87bf
Compare
martint
reviewed
Oct 13, 2022
core/trino-main/src/test/java/io/trino/sql/planner/assertions/JoinMatchPatternBuilder.java
Outdated
Show resolved
Hide resolved
Dith3r
force-pushed
the
issues/5976
branch
2 times, most recently
from
202237e to
f26762e
Compare
sopel39
approved these changes
Oct 14, 2022
core/trino-main/src/test/java/io/trino/sql/planner/AbstractPredicatePushdownTest.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/TestDynamicFilter.java
Outdated
Show resolved
Hide resolved
|
mind automation. There are compilation failures |
Dith3r
force-pushed
the
issues/5976
branch
2 times, most recently
from
f4d3e5d to
3592f99
Compare
kasiafi
requested changes
Oct 14, 2022
There was a problem hiding this comment.
I think it would be good to follow our usual practices around matchers.
We tend to put the Builder class within the corresponding Matcher class.
Additionally, we usually pass a builder handler, thus avoiding the call to the build() method in the tests.
Could you please refactor for consistency with the existing code? You can use the PatternRecognitionMatcher class as the example, and the PlanMatchPattern.patternRecognition() method for builder usage example.
sopel39
approved these changes
Oct 14, 2022
core/trino-main/src/test/java/io/trino/sql/planner/assertions/JoinMatcher.java
Show resolved
Hide resolved
Dith3r
changed the title
Dith3r
force-pushed
the
issues/5976
branch
2 times, most recently
from
57c0b28 to
ba5de57
Compare
kasiafi
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5976.
The Builder class was added to make assertions easier to create and remove the overload.
Non-technical explanation
Clean the test code.
Release notes
(x ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: