Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support query table function in MongoDB #14535

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Support query table function in MongoDB #14535

merged 1 commit into from
Oct 14, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Oct 9, 2022 •
edited
Loading

Description

Non-technical explanation

Release notes

(x) Release notes are required, with the following suggested text:

# MongoDB
* Add `query` table function for query pass-through to the connector. ({issue}`14535`)

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2022
@ebyhr ebyhr marked this pull request as ready for review October 11, 2022 09:25
@ebyhr ebyhr requested review from Praveen2112 and hashhar October 11, 2022 09:25
Praveen2112
Praveen2112 reviewed Oct 11, 2022
View reviewed changes
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoPageSource.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoTableHandle.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoTableHandle.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoTableHandle.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoTableHandle.java Outdated Show resolved Hide resolved
@ebyhr ebyhr changed the title Support raw_query table function in MongoDB Support query table function in MongoDB Oct 12, 2022
@github-actions github-actions bot added the docs label Oct 12, 2022
@ebyhr
Copy link
Member Author

ebyhr commented Oct 12, 2022

@Praveen2112 Addressed comments.

@ebyhr
Copy link
Member Author

ebyhr commented Oct 12, 2022

Addressed comments.

Praveen2112
Praveen2112 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% comments. LGTM

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/Query.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoConnectorTest.java Show resolved Hide resolved
Praveen2112
Praveen2112 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional question for my understanding.

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Show resolved Hide resolved
skrzypo987
skrzypo987 reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@skrzypo987 skrzypo987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, given my out-of-date knowledge of Mongo.

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/Query.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/Query.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoConnectorTest.java Show resolved Hide resolved
@ebyhr ebyhr merged commit 1e2eafb into trinodb:master Oct 14, 2022
@ebyhr ebyhr deleted the ebi/mongodb-ptf branch October 14, 2022 01:22
@ebyhr ebyhr mentioned this pull request Oct 14, 2022
Closed
@ebyhr ebyhr self-assigned this Oct 14, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 14, 2022
@colebow colebow mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrzypo987 skrzypo987 skrzypo987 left review comments

@Praveen2112 Praveen2112 Praveen2112 approved these changes

@hashhar hashhar Awaiting requested review from hashhar

@s2lomon s2lomon Awaiting requested review from s2lomon

Assignees

@ebyhr ebyhr

Labels
cla-signed docs
Milestone
401
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @Praveen2112 @skrzypo987