Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPM docs with a link to Helm docs #14524

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

sheajamba
Copy link
Member

Description

Adds a link to the Helm installation docs from the RPM installation page.

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Oct 7, 2022
@sheajamba sheajamba requested a review from mosabua October 7, 2022 17:29
@github-actions github-actions bot added the docs label Oct 7, 2022
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Oct 7, 2022
@ebyhr ebyhr merged commit 171959b into trinodb:master Oct 7, 2022
@ebyhr
Copy link
Member

ebyhr commented Oct 7, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 400 milestone Oct 8, 2022
It is recommended to deploy Trino with the :doc:`Helm chart <kubernetes>` on
Kubernetes or manually with the :doc:`Docker containers <containers>` or the
:doc:`tar archive <deployment>`. While the RPM is available for use, it is not
tested.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not tested

well, https://github.com/trinodb/trino/blob/master/core/trino-server-rpm/src/test/java/io/trino/server/rpm/ServerIT.java does exist

i think the docker container or helm charts may not be tested more than that, are they?

we should change to "not supported" or "discouraged".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

4 participants