Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session property documentation for writer scaling #14483

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

bendemott
Copy link
Contributor

@bendemott bendemott commented Oct 5, 2022

Description

The correct session property name for
task.scale-writers.enabled
is task_scale_writers_enabled

Non-technical explanation

Simple documentation fix

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

The correct session property name for
`task.scale-writers.max-writer-count
is task_scale_writers_enabled
@cla-bot
Copy link

cla-bot bot commented Oct 5, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@bendemott bendemott closed this Oct 5, 2022
@bendemott bendemott reopened this Oct 5, 2022
@github-actions github-actions bot added the docs label Oct 5, 2022
@bendemott bendemott changed the title Session property docs for task.scale-writers.max-writer-count is incorrect Session property docs for task.scale-writers.enable is incorrect Oct 6, 2022
@bendemott bendemott changed the title Session property docs for task.scale-writers.enable is incorrect Session property docs for task.scale-writers.enabled is incorrect Oct 6, 2022
@bendemott
Copy link
Contributor Author

bendemott commented Oct 6, 2022

@electrum In my hurry to create this I had the description wrong task.scale-writers.enabled -> task_scale_writers_enabled
CLA is signed, hopefully it updates in the next 24hrs

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@findepi findepi changed the title Session property docs for task.scale-writers.enabled is incorrect Fix session property documentation for writer scaling Oct 7, 2022
@findepi findepi merged commit 4ed05cc into trinodb:master Oct 7, 2022
@github-actions github-actions bot added this to the 400 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants