Include dictionaryLookBack size in MultiChannelGroupByHash size #14466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-stec
approved these changes
Oct 5, 2022
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Show resolved
Hide resolved
Dith3r
changed the title
sopel39
reviewed
Oct 5, 2022
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Show resolved
Hide resolved
Dith3r
force-pushed
the
master
branch
3 times, most recently
from
f81357f to
a0c2320
Compare
sopel39
approved these changes
Oct 6, 2022
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MultiChannelGroupByHash getEstimatedSize will include the size of DictionaryLookBack. DictionaryLookBack is preserved across input pages.
Non-technical explanation
Better memory utilization when using GroupBy.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: