Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure to FTE exchange manager docs #14442

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

sheajamba
Copy link
Member

Description

Adds Azure to the Exchange manager paragraph in the fault-tolerance execution docs.

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2022
@sheajamba sheajamba requested a review from mosabua October 3, 2022 14:37
@findepi findepi requested a review from arhimondr October 3, 2022 15:35
@github-actions github-actions bot added the docs label Oct 3, 2022
@sheajamba sheajamba force-pushed the azure-fault-tolerant-docs branch from 6ab3298 to 542ecfe Compare October 3, 2022 15:58
@sheajamba sheajamba requested a review from mosabua October 3, 2022 15:58
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Contributor

@arhimondr arhimondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

storage system, Google Cloud Storage (GCS), or a local filesystem.
that stores spooled data in a specified location, such as :ref:`AWS S3
<fte-exchange-aws-s3>` and S3-compatible systems, :ref:`Azure Blob Storage
<fte-exchange-azure-blob>`, :ref:`Google Cloud Storage <fte-exchange-gcs>`, or a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the mention of fte-exchange-local-filesystem. This implementation is built only for local testing and is not designed for production use cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheajamba can you do that...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or add something like "for testing"

@sheajamba sheajamba force-pushed the azure-fault-tolerant-docs branch from 542ecfe to 329009a Compare October 6, 2022 15:18
@sheajamba sheajamba requested review from mosabua and arhimondr October 6, 2022 15:19
@electrum electrum merged commit a05e841 into trinodb:master Oct 17, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants