Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details about explain plan generation #14385

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Sep 30, 2022

Description

Just expanding some of the headers into actual sentences and adding some further details. Also adding examples for validate failures.

This came up in slack but I cant find the thread anymore, so I am not sure who requested that update again..

Fixes #14377

Non-technical explanation

Improve documentation for EXPLAIN statement.

Release notes

(X) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2022
@mosabua mosabua requested a review from colebow September 30, 2022 00:15
@mosabua mosabua added docs and removed cla-signed labels Sep 30, 2022
@mosabua mosabua requested a review from findepi September 30, 2022 00:28
@findepi findepi requested review from sopel39 and removed request for findepi September 30, 2022 10:46
docs/src/main/sphinx/sql/explain.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/explain.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/explain.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/explain.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/explain.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/explain.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/explain.rst Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented Oct 11, 2022

@raunaqmorarka @sopel39 .. anything else or could this get merged?

@mosabua mosabua force-pushed the explain branch 2 times, most recently from d39210b to 989fcb7 Compare October 14, 2022 19:40
@mosabua
Copy link
Member Author

mosabua commented Oct 14, 2022

Sorry for the mess up @raunaqmorarka .. should be ready now

@raunaqmorarka raunaqmorarka merged commit 6931498 into trinodb:master Oct 15, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 15, 2022
@mosabua mosabua deleted the explain branch October 17, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Expand details for explain validate
4 participants