Cleanup test table in CLI product test #14323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2022
Closed
kokosing
approved these changes
Sep 27, 2022
findepi
force-pushed
the
findepi/cli-test-fix
branch
from
d54bf00 to
2050952
Compare
|
(just rebased; but there were failures https://github.com/trinodb/trino/actions/runs/3138792926/jobs/5099821200 ) |
If the table is left over, causes failure of `TestRoles`. `TestRoles` should not assume there are no Iceberg tables in the metastore, so this should be viewed as a quick-fix only.
findepi
force-pushed
the
findepi/cli-test-fix
branch
from
2050952 to
2eb96a0
Compare
|
(perhaps fixed the failures; i was missing a semicolon) |
hashhar
approved these changes
Sep 28, 2022
findepi
added
the
no-release-notes
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the table is left over, causes failure of
TestRoles.TestRolesshould not assume there are no Iceberg tables in themetastore, so this should be viewed as a quick-fix only.
Fixes master build failure occurring after #13907.
That PR was green when being merged.