Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification step for HTTPS/TLS docs #14297

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

sheajamba
Copy link
Member

Description

Adds a verification step to the Trino security overview page with a link to the steps to verify HTTPS/TLS configuration.

Non-technical explanation

Helps users verify if they have HTTPS/TLS configured correctly.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 26, 2022
@sheajamba sheajamba requested a review from mosabua September 26, 2022 17:44
docs/src/main/sphinx/security/tls.rst Show resolved Hide resolved
docs/src/main/sphinx/security/tls.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/security/tls.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/security/tls.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added the docs label Sep 26, 2022
@sheajamba sheajamba force-pushed the security-verification-https-docs branch from 08f4549 to 63482fc Compare September 27, 2022 19:01
@sheajamba sheajamba requested a review from mosabua September 28, 2022 13:18
@sheajamba sheajamba force-pushed the security-verification-https-docs branch from 63482fc to 4f3ae38 Compare October 17, 2022 20:08
docs/src/main/sphinx/security/tls.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/security/tls.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/security/tls.rst Outdated Show resolved Hide resolved
@sheajamba sheajamba force-pushed the security-verification-https-docs branch from 4f3ae38 to 74fb4e8 Compare October 18, 2022 19:18
@sheajamba sheajamba requested a review from mosabua October 18, 2022 19:18
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now. Can you merge this @dain

@electrum electrum merged commit 6ac4baa into trinodb:master Oct 24, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants