Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract TestJdbcStatement from TestJdbcConnection #14186

Conversation

findepi
Copy link
Member

@findepi findepi commented Sep 19, 2022

Extract statement tests into new class. This makes them easier to find, especially that we already have TestJdbcPreparedStatement for testing aspects of prepared statements.

Extract statement tests into new class. This makes them easier to find,
especially that we already have `TestJdbcPreparedStatement` for testing
aspects of _prepared_ statements.
@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Sep 19, 2022
@findepi findepi requested review from kokosing and hashhar September 19, 2022 10:15
@cla-bot cla-bot bot added the cla-signed label Sep 19, 2022
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Sep 19, 2022
@findepi findepi merged commit d40b68c into trinodb:master Sep 19, 2022
@findepi findepi deleted the findepi/extract-testjdbcstatement-from-testjdbcconnection-560945 branch September 19, 2022 20:27
@github-actions github-actions bot added this to the 397 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed jdbc Relates to Trino JDBC driver no-release-notes This pull request does not require release notes entry test
Development

Successfully merging this pull request may close these issues.

2 participants