Upgrade Pinot libraries to 0.11.0 #14090
Conversation
elonazoulay
force-pushed
the
pinot11
branch
from
24b8840 to
83aa956
Compare
| <groupId>org.basepom.maven</groupId> | ||
| <artifactId>duplicate-finder-maven-plugin</artifactId> | ||
| <configuration> | ||
| <ignoredDependencies> |
There was a problem hiding this comment.
What library is contributing the duplicates? Can we improve this by shading upstream?
There was a problem hiding this comment.
I saw it one due to the recent helix-core upgrade to 1.0.4. It brings several helix-* and they become duplicate each other, which I don't know the reason
There was a problem hiding this comment.
I saw the warning of duplicate same version. So I feel it's safe to ignore
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/client/PinotGrpcDataFetcher.java
Show resolved
Hide resolved
| // Add a null row, verify it was not ingested as pinot does not accept null time column values. | ||
| // The data is verified in testBrokerQueryWithTooManyRowsForSegmentQuery | ||
| tooManyRowsRecordsBuilder.add(new ProducerRecord<>(TOO_MANY_ROWS_TABLE, "key" + MAX_ROWS_PER_SPLIT_FOR_SEGMENT_QUERIES, new GenericRecordBuilder(tooManyRowsAvroSchema).build())); | ||
| //tooManyRowsRecordsBuilder.add(new ProducerRecord<>(TOO_MANY_ROWS_TABLE, "key" + MAX_ROWS_PER_SPLIT_FOR_SEGMENT_QUERIES, new GenericRecordBuilder(tooManyRowsAvroSchema).build())); |
There was a problem hiding this comment.
Probably extract this specific case to new test method and override it in <0.11?
| @@ -139,11 +139,12 @@ public void testDoubleWithScientificNotation() | |||
| @Test | |||
| public void testFilterWithCast() | |||
| { | |||
| // UPDATE: Pinot 0.11.0 automatically casts constants during parsing | |||
There was a problem hiding this comment.
Maybe it's safer to keep it, to verify the behavior? Or did you mean just remove the comment?
TestPinotWithoutAuthenticationIntegrationLatestVersionConnectorSmokeTest had a typo in the name.
| public static final String PINOT_LATEST_IMAGE_NAME = "apachepinot/pinot:0.10.0"; | ||
| public static final String PINOT_PREVIOUS_IMAGE_NAME = "apachepinot/pinot:0.9.3-jdk11"; | ||
| public static final String PINOT_LATEST_IMAGE_NAME = "apachepinot/pinot:0.11.0"; | ||
| public static final String PINOT_PREVIOUS_IMAGE_NAME = "apachepinot/pinot:0.10.0"; |
There was a problem hiding this comment.
lower bound of supported versions is now 0.10? Please update pinot.rst too accordingly.
|
any updates on this pr? |
Description
Non-technical explanation
Release notes
( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: