Remove Pinot Column Name Property

[elonazoulay]

Description

Add the column name property to Pinot column properties.
Fixes #14071

Non-technical explanation

The pinot column name property was missing so SHOW CREATE TABLE queries would fail.

Release notes

( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Pinot
* Fix failure when executing `SHOW CREATE TABLE` statement. ({issue}`14071`)

[findepi]

What's the "column name property" and how is it different from the column name?

cc @martint

[elonazoulay]

@findepi - The column name property is the pinot column name which may contain non lowercase characters.

[elonazoulay]

Looks like the hidden properties are included show create table.
Should hidden column properties be filtered out in ShowQueriesRewrite (below)?

Collection<PropertyMetadata<?>> allColumnProperties = columnPropertyManager.getAllProperties(tableHandle.getCatalogHandle());

@ebyhr @findepi

[findepi]

@findepi - The column name property is the pinot column name which may contain non lowercase characters.

We don't use "column property" in any other connector. Why did we consider Pinot to be special and require different approach?

[elonazoulay]

I don't want it to be special in that way:) iirc this was from the first version. Instead should I just keep a mapping?
Instead of being able to create a PinotColumnHandle directly from column metadata, should it look up the pinot "raw" column name? Assuming that's what you mean, lmk.

[findepi]

If agree that "column property" is the way to go, that's what we should be doing in other connectors, like PostgreSQL, MySQL, SQL Server, etc.
if we agree that "column property" way is not superior, Pinot connector shouldn't be doing that (unless there is some Pinot-specific reason to)

[elonazoulay]

I think it's better to remove it: since no other connectors use it and there is a way to do this without the column property then it makes more sense to remove it. Refactoring this pr. wdyt? (I'll save this branch just in case).

[elonazoulay]

Whenever you have a chance, I updated the pr to remove the property cc @findepi @ebyhr

[ebyhr]

Merged, thanks!