Add decimal type handling fragment to appropriate connectors #14084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fragment needs to be used somewhere.. |
Jessie212
force-pushed
the
jt/decimal-type-handling
branch
from
78efa8b to
45e7a83
Compare
Jessie212
changed the title
mosabua
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Looks good.. if this ever changes and is different for different connectors we can pull apart then. My one question would be if this also applies to other connectors like Oracle, MariaDB, and others. That is for an engineer to answer though.. as it stands now its an easy improvement that does NOT change the actual content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turn decimal type handling section into fragment.
Non-technical explanation
Release notes
( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: